Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove setters #434

Merged
merged 32 commits into from
Oct 30, 2024
Merged

remove setters #434

merged 32 commits into from
Oct 30, 2024

Conversation

asolntsev
Copy link
Contributor

No description provided.

@asolntsev
#429 [refactor] make class PagePosition immutable
df536f9 
* make all PagePosition.* fields final
* pass all values into constructor instead of using setters
@asolntsev
#429 [refactor] make class FontDescription immutable
2805e2c 
* make all `FontDescription.*` fields final
* pass all values into constructor instead of using setters
* extract few fields to an inner object `FontDescription.Decorations`
@asolntsev
#429 [refactor] make class ITextFSFontMetrics immutable
6eab044 
* make all `ITextFSFontMetrics.*` fields final
* pass all values into constructor instead of using setters
@asolntsev
#429 [refactor] return Optional instead of null from `ITextOutputDevi…
2189ed4 
…ce.checkLinkArea()`
@asolntsev asolntsev self-assigned this Oct 29, 2024
@asolntsev asolntsev added this to the 9.10.3 milestone Oct 29, 2024
@asolntsev
#429 [refactor] make class PDFAsImage immutable
6d9adeb 
* method `FSImage.scale` now returns a new `FSImage` (instead of modifying the current FSImage instance).
@asolntsev
#429 [refactor] make class PDFEncryption immutable
1b2835d
@asolntsev
#429 [refactor] make class PageRule almost immutable :)
f8bf190
@asolntsev
#429 [refactor] make method resetNegativeValues() return new instance
0ce4d71 
...instead of modifying the existing instance.
@asolntsev
#429 [refactor] make class FloatLayoutResult immutable
2ed9922
@asolntsev
#429 [refactor] make class FloatManager immutable
c185740
@asolntsev
#429 [refactor] convert constants FloatManager.{LEFT,RIGHT} to enum
ea82480
@asolntsev
#429 [refactor] make class FunctionData immutable
03b652b
@asolntsev
#429 [refactor] make class InlineBox more immutable :)
0ab7acc
@asolntsev
#429 [refactor] make few fields in LineBreakContext immutable or no…
1aa5a3f 
…n-nullable
@asolntsev
#429 [refactor] make class InlineBoxMeasurements immutable
bbc588c
@asolntsev
#429 [refactor] make field Layer._stackingContext immutable
8e31d9d
@asolntsev
#429 [refactor] convert constants Layer.{AUTO|NEGATIVE|POSITIVE|ZERO}…
f4e656c 
… to enum Width
@asolntsev
#429 [refactor] make class PaintingInfo immutable
b8aa47a
@asolntsev
#429 [refactor] replace few setters in InlineBoxMeasurements by con…
99761e0 
…structor parameters
@asolntsev
#429 [refactor] replace setElement() and setStyle() by constructo…
3223974 
…r parameters

(as much as possible)
@asolntsev
#429 [refactor] remove unused setter TableSectionBox.setGrid()
ad1643b
@asolntsev
#429 [refactor] replace Box.setAnonymous() by a constructor parameter
6839559
@asolntsev
#429 [refactor] make class BoxDimensions immutable
c13416d
@asolntsev
#429 [refactor] make class FloatDistances (and its subclasses) immu…
6313a0e 
…table
@asolntsev
#429 [refactor] make field InlineLayoutBox._containingBlockWidth im…
00b4cc4 
…mutable
@asolntsev
#429 [refactor] make class JustificationInfo immutable
89ca3d1
@asolntsev asolntsev merged commit afa6f17 into main Oct 30, 2024
4 checks passed
@asolntsev asolntsev deleted the refactoring/remove-setters branch October 30, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asolntsev asolntsev

Labels
refactoring
Projects
None yet
Milestone
9.11.0
Development

Successfully merging this pull request may close these issues.
1 participant
@asolntsev