fix suggestions

Signed-off-by: troychiu <[email protected]>
flyteorg · Mar 15, 2024 · 1608f89 · 1608f89
1 parent 3f9c131
commit 1608f89
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/flyteadmin/tests/attributes_test.go b/flyteadmin/tests/attributes_test.go
@@ -39,7 +39,7 @@ func TestUpdateClusterResourceAttributes(t *testing.T) {
 	ctx := context.Background()
 	client, conn := GetTestAdminServiceClient()
 	defer conn.Close()
-	db, err := repositories.GetDB(ctx, getDbConfig(), getLoggerConfig())
+	db, err := repositories.GetDB(ctx, getDbConfigWithEnv(), getLoggerConfig())
 	assert.Nil(t, err)
 	truncateTableForTesting(db, "resources")
 	sqlDB, err := db.DB()
@@ -130,7 +130,7 @@ func TestUpdateProjectDomainAttributes(t *testing.T) {
 	ctx := context.Background()
 	client, conn := GetTestAdminServiceClient()
 	defer conn.Close()
-	db, err := repositories.GetDB(ctx, getDbConfig(), getLoggerConfig())
+	db, err := repositories.GetDB(ctx, getDbConfigWithEnv(), getLoggerConfig())
 	assert.Nil(t, err)
 	truncateTableForTesting(db, "resources")
 	sqlDB, err := db.DB()
@@ -242,7 +242,7 @@ func TestUpdateWorkflowAttributes(t *testing.T) {
 	client, conn := GetTestAdminServiceClient()
 	defer conn.Close()
 
-	db, err := repositories.GetDB(ctx, getDbConfig(), getLoggerConfig())
+	db, err := repositories.GetDB(ctx, getDbConfigWithEnv(), getLoggerConfig())
 	assert.Nil(t, err)
 	truncateTableForTesting(db, "resources")
 	sqlDB, err := db.DB()
@@ -303,7 +303,7 @@ func TestListAllMatchableAttributes(t *testing.T) {
 	client, conn := GetTestAdminServiceClient()
 	defer conn.Close()
 
-	db, err := repositories.GetDB(ctx, getDbConfig(), getLoggerConfig())
+	db, err := repositories.GetDB(ctx, getDbConfigWithEnv(), getLoggerConfig())
 	assert.Nil(t, err)
 	truncateTableForTesting(db, "resources")
 	sqlDB, err := db.DB()

diff --git a/flyteadmin/tests/bootstrap.go b/flyteadmin/tests/bootstrap.go
@@ -26,13 +26,13 @@ var adminScope = promutils.NewScope("flyteadmin")
 
 func getDbConfigWithEnv() *database.DbConfig {
 	if os.Getenv(integrationTestConfigEnvVar) == "True" {
-		return getDbConfig()
+		return getIntegrationDbConfig()
 	} else {
 		return getSandboxDbConfig()
 	}
 }
 
-func getDbConfig() *database.DbConfig {
+func getIntegrationDbConfig() *database.DbConfig {
 	return &database.DbConfig{
 		Postgres: database.PostgresConfig{
 			Host:   "postgres",

diff --git a/flyteadmin/tests/execution_test.go b/flyteadmin/tests/execution_test.go
@@ -157,7 +157,7 @@ func populateWorkflowExecutionsForTestingOnly() {
 		fmt.Sprintf(insertExecutionQueryStr, "project1", "domain2", "name1", "RUNNING", 1, 2),
 		fmt.Sprintf(insertExecutionQueryStr, "project2", "domain2", "name1", "SUCCEEDED", 1, 2),
 	}
-	db, err := repositories.GetDB(context.Background(), getDbConfig(), getLoggerConfig())
+	db, err := repositories.GetDB(context.Background(), getDbConfigWithEnv(), getLoggerConfig())
 	ctx := context.Background()
 	if err != nil {
 		logger.Fatalf(ctx, "Failed to open DB connection due to %v", err)