couple small items

Signed-off-by: Yee Hing Tong <[email protected]>
flyteorg · Oct 30, 2023 · 23d5fc2 · 23d5fc2
1 parent bdddc93
commit 23d5fc2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/flyteadmin/flyteadmin_config.yaml b/flyteadmin/flyteadmin_config.yaml
@@ -118,9 +118,8 @@ externalEvents:
     eventTypes: all
 cloudEvents:
   enable: true
-  type: redis
-  redis:
-    addr: "localhost:6379"
+  cloudEventVersion: v2
+  type: sandbox
 Logger:
   show-source: true
   level: 5

diff --git a/flyteadmin/pkg/async/cloudevent/implementations/sender.go b/flyteadmin/pkg/async/cloudevent/implementations/sender.go
@@ -24,10 +24,7 @@ type PubSubSender struct {
 }
 
 func (s *PubSubSender) Send(ctx context.Context, notificationType string, event cloudevents.Event) error {
-	// gatepr: investigate why the previous statement didn't work.
-	//  perhaps only because of redis.
 	eventByte, err := pbcloudevents.Protobuf.Marshal(&event)
-	//eventByte, err := json.Marshal(&event)
 	if err != nil {
 		logger.Errorf(ctx, "Failed to marshal cloudevent with error: %v", err)
 		return err