Skip to content

Commit

Permalink
Update storage config in value-gcp.yaml
Browse files Browse the repository at this point in the history
Signed-off-by: Kevin Su <[email protected]>
  • Loading branch information
pingsutw committed Mar 5, 2024
1 parent 4a95abf commit 74b0a1b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
16 changes: 9 additions & 7 deletions charts/flyte-core/values-gcp.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -194,14 +194,16 @@ common:
#

storage:
# -- Sets the storage type. Supported values are sandbox, s3, gcs and custom.
type: gcs
# -- Sets the storage type. Supported values are s3/minio/local/mem/stow.
type: stow
stow:
kind: google
config:
json: ""
project_id: "{{ .Values.userSettings.googleProjectId }}"
scopes: https://www.googleapis.com/auth/cloud-platform
# -- bucketName defines the storage bucket flyte will use. Required for all types except for sandbox.
bucketName: "{{ .Values.userSettings.bucketName }}"
# -- settings for storage type s3
gcs:
# -- GCP project ID. Required for storage type gcs.
projectId: "{{ .Values.userSettings.googleProjectId }}"
container: "{{ .Values.userSettings.bucketName }}"

db:
datacatalog:
Expand Down
2 changes: 1 addition & 1 deletion flytestdlib/storage/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ type Config struct {

// Container here is misleading, it refers to a Bucket (AWS S3) like blobstore entity. In some terms it could be a table
InitContainer string `json:"container" pflag:",Initial container (in s3 a bucket) to create -if it doesn't exist-.'"`
// By default if this is not enabled, multiple containers are not supported by the storage layer. Only the configured `container` InitContainer will be allowed to requests data from. But, if enabled then data will be loaded to written to any
// By default, if this is not enabled, multiple containers are not supported by the storage layer. Only the configured `container` InitContainer will be allowed to requests data from. But, if enabled then data will be loaded to written to any
// container specified in the DataReference.
MultiContainerEnabled bool `json:"enable-multicontainer" pflag:",If this is true, then the container argument is overlooked and redundant. This config will automatically open new connections to new containers/buckets as they are encountered"`
// Caching is recommended to improve the performance of underlying systems. It caches the metadata and resolving
Expand Down

0 comments on commit 74b0a1b

Please sign in to comment.