Skip to content

Commit

Permalink
Adapt docstring explaining why we treat queued and init phase the sam…
Browse files Browse the repository at this point in the history
…e while filtering log links
  • Loading branch information
fg91 committed Apr 7, 2024
1 parent a6b9174 commit 8a8bdf1
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions flyteadmin/pkg/repositories/transformers/task_execution.go
Original file line number Diff line number Diff line change
Expand Up @@ -379,8 +379,9 @@ func filterLogsByPhase(logs []*core.TaskLog, phase core.TaskExecution_Phase) []*
if common.IsTaskExecutionTerminal(phase) && l.HideOnceFinished {
continue
}
// Some plugins like e.g. Dask start with core.TaskExecution_INITIALIZING once the CRD has been created
// even though the underlying pods are pending.
// Some plugins like e.g. Dask, Ray start with or very quickly transition to core.TaskExecution_INITIALIZING
// once the CR has been created even though the underlying pods are still pending. We thus treat queued and
// initializing the same here.
if (phase == core.TaskExecution_QUEUED || phase == core.TaskExecution_INITIALIZING) && !l.ShowWhilePending {
continue
}
Expand Down

0 comments on commit 8a8bdf1

Please sign in to comment.