Skip to content

Commit

Permalink
Forgot one change
Browse files Browse the repository at this point in the history
Signed-off-by: Neil Stout <[email protected]>
  • Loading branch information
neilisaur committed Mar 14, 2024
1 parent 0841046 commit b621f2e
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -130,13 +130,13 @@ func DecorateEnvVars(ctx context.Context, envVars []v1.EnvVar, taskEnvironmentVa

envFroms := []v1.EnvFromSource{}

for _, secretName := range config.GetK8sPluginConfig().DefaultEnvVarsFromSecrets {
for _, secretName := range config.GetK8sPluginConfig().DefaultEnvFromSecrets {
optional := true
secretRef := v1.SecretEnvSource{v1.LocalObjectReference{Name: secretName}, &optional}
envFroms = append(envFroms, v1.EnvFromSource{SecretRef: &secretRef})
}

Check warning on line 137 in flyteplugins/go/tasks/pluginmachinery/flytek8s/k8s_resource_adds.go

View check run for this annotation

Codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/flytek8s/k8s_resource_adds.go#L134-L137

Added lines #L134 - L137 were not covered by tests

for _, cmName := range config.GetK8sPluginConfig().DefaultEnvVarsFromConfigMaps {
for _, cmName := range config.GetK8sPluginConfig().DefaultEnvFromConfigMaps {
optional := true
cmRef := v1.ConfigMapEnvSource{v1.LocalObjectReference{Name: cmName}, &optional}
envFroms = append(envFroms, v1.EnvFromSource{ConfigMapRef: &cmRef})
Expand Down

0 comments on commit b621f2e

Please sign in to comment.