OIDC config to allow mismatched discovery / issuer #5712
Conversation
- There are a number of cases where the OIDC discovery url returns one issuer, but its desirable to use a separately configured / named issuer for validation instead. There are cases in Azure where this is necessary due to their non-standard OIDC configuration -- which is why this was originally added: coreos/go-oidc#315 There are also cases where it's necessary to use an in-cluster service address, but browser clients are using the external ingress address. Due to cluster DNS configuration, it's possible that flyteadmin may be unable to resolve or use the public ingress address for an Idp, but the internal service address is available. This configuration change allows for that. Signed-off-by: ddl-ebrown <[email protected]>
ddl-ebrown
force-pushed
the
add-oidc-issuer-configuration
branch
from
14474be to
d897dfb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5712 +/- ##
==========================================
+ Coverage 34.28% 36.17% +1.88%
==========================================
Files 1137 1303 +166
Lines 102263 109665 +7402
==========================================
+ Hits 35065 39667 +4602
- Misses 63546 65853 +2307
- Partials 3652 4145 +493
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Had a chat with @EngHabu. This pr is good to go thank you! There was some discussion about whether this config option needs to be piped in to the resource_server so that the issuer can be verified but it looks like we don't do that. In the self auth server case, the issuer is already read from config or matched against authorized urls so that's okay.
|
mind taking care of the checks though @ddl-ebrown |
Tracking issue
Why are the changes needed?
There are a number of cases where the OIDC discovery url returns one issuer, but its desirable to use a separately configured / named issuer for validation instead.
There are cases in Azure where this is necessary due to their non-standard OIDC configuration -- which is why this was originally added: oidc: add option to override discovered issuer URL coreos/go-oidc#315
There are also cases where it's necessary to use an in-cluster service address, but browser clients are using the external ingress address. Due to cluster DNS configuration, it's possible that flyteadmin may be unable to resolve or use the public ingress address for an Idp, but the internal service address is available. This configuration change allows for that.
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link