Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC config to allow mismatched discovery / issuer #5712

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OIDC config to allow mismatched discovery / issuer #5712

wants to merge 1 commit into from

Commits on Aug 31, 2024

  1. OIDC config to allow mismatched discovery / issuer 

     - There are a number of cases where the OIDC discovery url returns one
   issuer, but its desirable to use a separately configured / named
   issuer for validation instead.

   There are cases in Azure where this is necessary due to their
   non-standard OIDC configuration -- which is why this was originally
   added:
   coreos/go-oidc#315

   There are also cases where it's necessary to use an in-cluster
   service address, but browser clients are using the external ingress
   address. Due to cluster DNS configuration, it's possible that
   flyteadmin may be unable to resolve or use the public ingress
   address for an Idp, but the internal service address is available.
   This configuration change allows for that.

Signed-off-by: ddl-ebrown <[email protected]>
    @ddl-ebrown
    ddl-ebrown committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    d897dfb View commit details
    Browse the repository at this point in the history