-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tag to ExecutionModel #4185
base: master
Are you sure you want to change the base?
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4185 +/- ##
==========================================
+ Coverage 59.52% 59.98% +0.46%
==========================================
Files 639 570 -69
Lines 54611 41225 -13386
==========================================
- Hits 32506 24728 -7778
+ Misses 19543 14098 -5445
+ Partials 2562 2399 -163
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Da-Yi Wu <[email protected]>
Signed-off-by: Da-Yi Wu <[email protected]>
27acf6c
to
af77f31
Compare
Signed-off-by: Da-Yi Wu <[email protected]>
Signed-off-by: Da-Yi Wu <[email protected]> Modify UpdateExecutionModelTag Signed-off-by: Da-Yi Wu <[email protected]> Update the Tags into Execution.Tag Signed-off-by: Da-Yi Wu <[email protected]> Update Execution Tag(flyteorg#4142) Signed-off-by: Da-Yi Wu <[email protected]> Add unit test for add tags Signed-off-by: Da-Yi Wu <[email protected]> Add unit test for add tag (flyteorg#4185) Signed-off-by: Da-Yi Wu <[email protected]> Add Tags Signed-off-by: Da-Yi Wu <[email protected]>
1dc7f31
to
d40d544
Compare
Signed-off-by: Da-Yi Wu <[email protected]>
Describe your changes
Enable users to add tags to their existing execution. It can perform the execution update operation directly through an HTTP PUT request. The detailed example are shown in screenshot using postman.
Check all the applicable boxes
Screenshots
Initialization:
After PUT Request: (curl -X PUT -H "Content-Type: application/json" -d '{"add_tags": ["tags2"]}' ...)
##ScreentShot in Database
Create the corresponding identity in admin tag DB table
The corresponding execution admin tags DB table
##Tracking PR
#4142