Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag to ExecutionModel #4185

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ericwudayi
Copy link

@ericwudayi ericwudayi commented Oct 7, 2023

Describe your changes

Enable users to add tags to their existing execution. It can perform the execution update operation directly through an HTTP PUT request. The detailed example are shown in screenshot using postman.

  1. Add add_tag in ExecutionUpdateRequest (flyteidl/protos/admin/execution.proto).
  2. Implement add tag details in flyteadmin.
  3. Adding test for UpdateExecutionModel and UpdateExecutionModelAddTag
pyflyte run --tag abc --tag tags1 --remote example.py training_workflow --hyperparameters '{"C": 0.1}'
//Go to http://localhost:30080/console/projects/flytesnacks/domains/development/executions/f5300f7f411674b89998 to see execution in the console.

## Put request, adding tags2 into the workflow
curl -X PUT -H "Content-Type: application/json" -d '{"add_tags": ["tags2"]}' http://localhost:30080/api/v1/executions/flytesnacks/development/f5300f7f411674b89998

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Initialization:
Screenshot 2023-10-15 at 9 31 27 AM

After PUT Request: (curl -X PUT -H "Content-Type: application/json" -d '{"add_tags": ["tags2"]}' ...)
Screenshot 2023-10-15 at 9 36 49 AM

##ScreentShot in Database
Create the corresponding identity in admin tag DB table
Screenshot 2023-10-15 at 9 38 43 AM

The corresponding execution admin tags DB table
Screenshot 2023-10-15 at 9 41 30 AM

##Tracking PR
#4142

@welcome
Copy link

welcome bot commented Oct 7, 2023

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@ericwudayi ericwudayi marked this pull request as ready for review October 8, 2023 08:17
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2edc3bd) 59.52% compared to head (5d07c5f) 59.98%.
Report is 9 commits behind head on master.

❗ Current head 5d07c5f differs from pull request most recent head d23227e. Consider uploading reports for the commit d23227e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4185      +/-   ##
==========================================
+ Coverage   59.52%   59.98%   +0.46%     
==========================================
  Files         639      570      -69     
  Lines       54611    41225   -13386     
==========================================
- Hits        32506    24728    -7778     
+ Misses      19543    14098    -5445     
+ Partials     2562     2399     -163     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flyteadmin/pkg/manager/impl/execution_manager.go 72.92% <0.00%> (+2.39%) ⬆️
...teadmin/pkg/repositories/transformers/execution.go 83.70% <81.81%> (+2.35%) ⬆️

... and 574 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ericwudayi added a commit to ericwudayi/flyte that referenced this pull request Oct 14, 2023
ericwudayi added a commit to ericwudayi/flyte that referenced this pull request Oct 15, 2023
ericwudayi added a commit to ericwudayi/flyte that referenced this pull request Oct 15, 2023
Signed-off-by: Da-Yi Wu <[email protected]>

Modify UpdateExecutionModelTag

Signed-off-by: Da-Yi Wu <[email protected]>

Update the Tags into Execution.Tag

Signed-off-by: Da-Yi Wu <[email protected]>

Update Execution Tag(flyteorg#4142)

Signed-off-by: Da-Yi Wu <[email protected]>

Add unit test for add tags

Signed-off-by: Da-Yi Wu <[email protected]>

Add unit test for add tag (flyteorg#4185)

Signed-off-by: Da-Yi Wu <[email protected]>

Add Tags

Signed-off-by: Da-Yi Wu <[email protected]>
Signed-off-by: Da-Yi Wu <[email protected]>
@github-actions github-actions bot added the stale label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant