Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support failure node #4308

Merged
merged 24 commits into from
Dec 9, 2023

Merge branch 'master' into failure_node

340f535
Select commit
Loading
Failed to load commit list.
Merged

Add support failure node #4308

Merge branch 'master' into failure_node
340f535
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 9, 2023 in 1s

58.98% (+0.05%) compared to b50ba87

View this Pull Request on Codecov

58.98% (+0.05%) compared to b50ba87

Details

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (b50ba87) 58.92% compared to head (340f535) 58.98%.

Files Patch % Lines
...er/pkg/controller/nodes/subworkflow/subworkflow.go 0.00% 10 Missing ⚠️
flytepropeller/pkg/controller/workflow/executor.go 68.18% 7 Missing ⚠️
...peller/pkg/controller/nodes/subworkflow/handler.go 40.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4308      +/-   ##
==========================================
+ Coverage   58.92%   58.98%   +0.05%     
==========================================
  Files         620      621       +1     
  Lines       52441    52483      +42     
==========================================
+ Hits        30903    30957      +54     
+ Misses      19073    19059      -14     
- Partials     2465     2467       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov