Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including securityContext as configurable options with defaults set. #4894

Conversation

neilisaur
Copy link
Contributor

@neilisaur neilisaur commented Feb 13, 2024

Tracking issue

#4893

Closes #4893

Why are the changes needed?

Without chart modifications, we are unable to deploy the flyte-core chart into OpenShift environments or other k8s environments that do not allow specification of user IDs.

What changes were proposed in this pull request?

Adds ability to override securityContext in Helm chart deployment for flyteadmin, flyteconsole, datacatalog, flytepropeller, and flytescheduler.

How was this patch tested?

Deployed in an on-prem environment.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Feb 13, 2024
Signed-off-by: Neil Stout <[email protected]>
@neilisaur neilisaur marked this pull request as draft February 13, 2024 18:37
@neilisaur neilisaur marked this pull request as ready for review February 13, 2024 18:51
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. documentation Improvements or additions to documentation and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Feb 13, 2024
@davidmirror-ops
Copy link
Contributor

cc @ddl-ebrown

@neilisaur neilisaur closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot override securityContext in flyte-core deployments
2 participants