Adding securityContext configuration to flyte-core charts #4895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Stout <[email protected]>
dosubot
bot
added
size:L
Signed-off-by: Neil Stout <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4895 +/- ##
=======================================
Coverage 58.97% 58.97%
=======================================
Files 645 645
Lines 55162 55162
=======================================
Hits 32532 32532
Misses 20055 20055
Partials 2575 2575
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@neilisaur to fix the generate_helm test failure, you should be able to run |
Signed-off-by: Neil Stout <[email protected]>
|
Congrats on merging your first pull request! 🎉 |
katrogan
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Adding securityContext configuration to flyte-core charts Signed-off-by: Neil Stout <[email protected]> * Removing S3 endpoint location Signed-off-by: Neil Stout <[email protected]> * Updates from make helm Signed-off-by: Neil Stout <[email protected]> --------- Signed-off-by: Neil Stout <[email protected]> Signed-off-by: Katrina Rogan <[email protected]>
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
) * Adding securityContext configuration to flyte-core charts Signed-off-by: Neil Stout <[email protected]> * Removing S3 endpoint location Signed-off-by: Neil Stout <[email protected]> * Updates from make helm Signed-off-by: Neil Stout <[email protected]> --------- Signed-off-by: Neil Stout <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #4893
Why are the changes needed?
Without chart modifications, we are unable to deploy the flyte-core chart into OpenShift environments or other k8s environments that do not allow specification of user IDs.
What changes were proposed in this pull request?
Adds ability to override securityContext in Helm chart deployment for flyteadmin, flyteconsole, datacatalog, flytepropeller, and flytescheduler.
How was this patch tested?
Deployed in an on-prem environment.
Setup process
Screenshots
Check all the applicable boxes