fix: mount flyte-secret-auth secret conditionally #4914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Lo <[email protected]>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
dosubot
bot
added
size:XS
…oyment.yaml Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
dosubot
bot
added
size:S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4914 +/- ##
==========================================
- Coverage 58.92% 58.91% -0.02%
==========================================
Files 645 645
Lines 55380 55380
==========================================
- Hits 32635 32629 -6
- Misses 20163 20167 +4
- Partials 2582 2584 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Congrats on merging your first pull request! 🎉 |
2 tasks
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Ryan Lo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #4908
Why are the changes needed?
If .Values.secrets.adminOauthClientCredentials.enabled is false in flyte-core chart, some deployments will mount flyte-secret-auth secret even though the secret isn't created.
What changes were proposed in this pull request?
Add conditional brach volume and volumeMount to make creation of secret and volume mount are consistent
How was this patch tested?
Can test it locally via
helm template charts/flyte-coreScreenshots
Check all the applicable boxes
Related PRs
Docs link