Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further edits to agents docs #4952

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Further edits to agents docs #4952

merged 4 commits into from
Feb 26, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Feb 26, 2024

Why are the changes needed?

In this PR:

  • Updates needed to create a new "Deprecated integrations" section
  • Copy edits for the recently published agents docs

NOTE: merge flyteorg/flytesnacks#1528 first, then merge this PR immediately after.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Docs link

TBD

nikki everett added 2 commits February 24, 2024 15:43
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
@neverett neverett requested a review from ppiegaze as a code owner February 26, 2024 00:07
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Feb 26, 2024
@neverett neverett self-assigned this Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.97%. Comparing base (94e433b) to head (daa8a9f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4952   +/-   ##
=======================================
  Coverage   58.96%   58.97%           
=======================================
  Files         645      645           
  Lines       55506    55506           
=======================================
+ Hits        32730    32733    +3     
+ Misses      20177    20173    -4     
- Partials     2599     2600    +1     
Flag Coverage Δ
unittests 58.97% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: nikki everett <[email protected]>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 26, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Feb 26, 2024
@neverett neverett requested a review from pingsutw February 26, 2024 17:38
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 26, 2024
@neverett neverett merged commit 0c771ef into master Feb 26, 2024
49 checks passed
@neverett neverett deleted the docs/agents-edits branch February 26, 2024 20:03
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
* copy edits

Signed-off-by: nikki everett <[email protected]>

* add anchor link

Signed-off-by: nikki everett <[email protected]>

* add note about contribution

Signed-off-by: nikki everett <[email protected]>

* add deprecated integrations section, update agents links

Signed-off-by: nikki everett <[email protected]>

---------

Signed-off-by: nikki everett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants