Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failure node example from flytesnacks #1328 #4958

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

neverett
Copy link
Contributor

Why are the changes needed?

Adds failure node example from flyteorg/flytesnacks#1328 since user guide docs now live in this repo.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

flyteorg/flytesnacks#1328

Docs link

TBD

@neverett neverett self-assigned this Feb 26, 2024
@neverett neverett requested a review from ppiegaze as a code owner February 26, 2024 19:49
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. documentation Improvements or additions to documentation labels Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.00%. Comparing base (311de70) to head (e1cb971).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4958   +/-   ##
=======================================
  Coverage   59.00%   59.00%           
=======================================
  Files         645      645           
  Lines       55518    55518           
=======================================
+ Hits        32758    32759    +1     
+ Misses      20164    20163    -1     
  Partials     2596     2596           
Flag Coverage Δ
unittests 59.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pingsutw
pingsutw previously approved these changes Feb 27, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 27, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Feb 27, 2024
@neverett neverett requested a review from pingsutw February 27, 2024 21:09
@neverett neverett merged commit d0d1b7f into master Feb 28, 2024
49 checks passed
@neverett neverett deleted the docs/add-failure-node-example branch February 28, 2024 16:10
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
* add failure node example from flyteorg/flytesnacks#1328

Signed-off-by: nikki everett <[email protected]>

* fix formatting and index toc

Signed-off-by: nikki everett <[email protected]>

* copy edits

Signed-off-by: nikki everett <[email protected]>

---------

Signed-off-by: nikki everett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants