Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting IsParent metadata in ArrayNode eventing #4967

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

hamersaw
Copy link
Contributor

Tracking issue

NA

Why are the changes needed?

If IsParent is set flyteconsole will continually attempt to retrieve child node executions. In the case of ArrayNode, child node executions are only populated with the eventing scheme == 1.

What changes were proposed in this pull request?

Only setting IsParent on the node execution metadata if the array node event version is 1.

How was this patch tested?

locally.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Feb 27, 2024
@hamersaw hamersaw requested a review from pvditt February 27, 2024 21:01
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 59.00%. Comparing base (311de70) to head (d8def2c).
Report is 1 commits behind head on master.

Files Patch % Lines
...lytepropeller/pkg/controller/nodes/transformers.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4967   +/-   ##
=======================================
  Coverage   59.00%   59.00%           
=======================================
  Files         645      645           
  Lines       55518    55520    +2     
=======================================
+ Hits        32758    32760    +2     
- Misses      20164    20165    +1     
+ Partials     2596     2595    -1     
Flag Coverage Δ
unittests 59.00% <25.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 28, 2024
@hamersaw hamersaw merged commit eaac04d into master Feb 28, 2024
48 of 49 checks passed
@hamersaw hamersaw deleted the bug/arraynode-is-parent branch February 28, 2024 14:40
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants