Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Remove sandbox lite #4996

Merged
merged 3 commits into from
Mar 10, 2024
Merged

[Housekeeping] Remove sandbox lite #4996

merged 3 commits into from
Mar 10, 2024

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Mar 4, 2024

Why are the changes needed?

Since Sandbox lite has been deprecated for a while, we can remove it now.

Signed-off-by: Kevin Su <[email protected]>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. housekeeping Issues that help maintain flyte and keep it tech-debt free labels Mar 4, 2024
@pingsutw pingsutw changed the title Remove sandbox lite [Housekeeping] Remove sandbox lite Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.00%. Comparing base (a946070) to head (b3015d1).
Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4996      +/-   ##
==========================================
+ Coverage   58.97%   59.00%   +0.03%     
==========================================
  Files         645      645              
  Lines       55561    55548      -13     
==========================================
+ Hits        32767    32776       +9     
+ Misses      20199    20181      -18     
+ Partials     2595     2591       -4     
Flag Coverage Δ
unittests 59.00% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw self-assigned this Mar 5, 2024
@pingsutw pingsutw requested a review from eapolinario March 5, 2024 23:18
eapolinario
eapolinario previously approved these changes Mar 7, 2024
docker/sandbox-bundled/README.md Show resolved Hide resolved
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 7, 2024
Signed-off-by: Kevin Su <[email protected]>
Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@pingsutw pingsutw enabled auto-merge (squash) March 10, 2024 09:00
@pingsutw pingsutw merged commit 24e8bc7 into master Mar 10, 2024
50 checks passed
@pingsutw pingsutw deleted the remove-sandbox-lite branch March 10, 2024 09:18
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants