Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UrlBlob and all related code #5005

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iaroslav-ciupin
Copy link
Contributor

Tracking issue

https://github.com/flyteorg/flyte/issues/

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@iaroslav-ciupin iaroslav-ciupin force-pushed the remove-deprecated-urlblob branch from 217b6de to 98c9f77 Compare March 5, 2024 18:00
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.77%. Comparing base (2adaf61) to head (98c9f77).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5005      +/-   ##
==========================================
+ Coverage   58.97%   59.77%   +0.79%     
==========================================
  Files         645      463     -182     
  Lines       55562    37635   -17927     
==========================================
- Hits        32768    22495   -10273     
+ Misses      20199    13447    -6752     
+ Partials     2595     1693     -902     
Flag Coverage Δ
unittests 59.77% <ø> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrogan
Copy link
Contributor

katrogan commented Mar 5, 2024

this is great, confirmed with the UI team that they aren't reading the deprecated fields

can you run through a few exercises to verify this doesn't break anything? you should be able to test this locally using the flyte sandbox (https://docs.flyte.org/en/latest/community/contribute.html#how-to-setup-dev-environment-for-flyteidl-flyteadmin-flyteplugins-flytepropeller-datacatalog-and-flytestdlib)

  1. verify that recovery works for an execution with multiple nodes (can abort the first attempt mid-way through, after one at least one node succeeds)
  2. verify flytekit remote access works (https://docs.flyte.org/en/latest/api/flytekit/remote.html#remote-access) - i believe it should based on this fallback: https://github.com/flyteorg/flytekit/blob/1c0b22813ec91625a597a4248f4b547d7c62c52b/flytekit/remote/remote.py#L1915-L1939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants