Nested parallelization #5022
Merged
Nested parallelization #5022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pryce-turner <[email protected]>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5022 +/- ##
==========================================
- Coverage 59.00% 58.99% -0.01%
==========================================
Files 645 645
Lines 55548 55548
==========================================
- Hits 32775 32770 -5
- Misses 20182 20187 +5
Partials 2591 2591
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: pryce-turner <[email protected]>
Signed-off-by: pryce-turner <[email protected]>
Signed-off-by: pryce-turner <[email protected]>
neverett
previously approved these changes
Mar 9, 2024
| @@ -0,0 +1,190 @@ | |||
| --- | |||
There was a problem hiding this comment.
I think you can remove this entire block of frontmatter -- the contents of the Python sections will render correctly without it.
Adding most suggestions with a few that need to be handled locally! Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: pryce-turner <[email protected]>
Signed-off-by: pryce-turner <[email protected]>
neverett
approved these changes
Mar 11, 2024
dosubot
bot
added
size:L
|
Congrats on merging your first pull request! 🎉 |
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
* Nested parallelization first draft Signed-off-by: pryce-turner <[email protected]> * Added screenshots and considerations section Signed-off-by: pryce-turner <[email protected]> * Spelling Signed-off-by: pryce-turner <[email protected]> * toctree Signed-off-by: pryce-turner <[email protected]> * Apply suggestions from code review Adding most suggestions with a few that need to be handled locally! Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: pryce-turner <[email protected]> * Merge * Updated screenshot with annotation Signed-off-by: pryce-turner <[email protected]> --------- Signed-off-by: pryce-turner <[email protected]> Signed-off-by: pryce-turner <[email protected]> Co-authored-by: Nikki Everett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of advanced users are curious about best practices when it comes to nesting and mixed parallelization. This PR adds a section under Advanced Composition showing a few examples and best practices.
This is just an unfinished draft but wanted to solicit early feedback.