helm: Add support for passing env variables to flyteadmin using envFrom

[ctso]

Tracking issue

Related to #3970

Why are the changes needed?

Users may want to pass environment variables from Secrets or ConfigMaps instead of relying on the Helm chart's flyteadmin.secrets Helm value. This is convenient when using a secrets manager such as External Secrets, for example.

What changes were proposed in this pull request?

Add a new Helm value, flyteadmin.envFrom which you can pass through directly to the underlying Deployment.

How was this patch tested?

Tested locally using helm template, it works.

Setup process

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

Docs link

[welcome]

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

• Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
• Sign off your commits (Reference: DCO Guide).

[wild-endeavor]

Should we match

flyte/charts/flyte-binary/templates/deployment.yaml

Line 169 in ab95f7e

envFrom:

?

[wild-endeavor]

@ctso I think it would feel nicer if at least the value var names matched between single binary and flyte-core. yah?

[davidmirror-ops]

@ctso what are we missing to ship this? There are users dealing with limitations where this feature would be helpful

[ctso]

I think this could be merged as-is, though it sounds like maybe we want to update the single binary chart to have the same behavior as well?

[davidmirror-ops]

@wild-endeavor not sure I follow, what you mean is matching in flyte-core the way this section enables envVars from different sources?

flyte/charts/flyte-binary/templates/deployment.yaml

Lines 169 to 177 in 0eaa20e

	envFrom:
	{{- if .Values.deployment.extraEnvVarsConfigMap }}
	- configMapRef:
	name: {{ .Values.deployment.extraEnvVarsConfigMap }}
	{{- end }}
	{{- if .Values.deployment.extraEnvVarsSecret }}
	- secretRef:
	name: {{ .Values.deployment.extraEnvVarsSecret }}
	{{- end }}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.03%. Comparing base (121665d) to head (21c9740).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5216   +/-   ##
=======================================
  Coverage   37.03%   37.03%           
=======================================
  Files        1318     1318           
  Lines      132267   132267           
=======================================
+ Hits        48980    48986    +6     
+ Misses      79028    79022    -6     
  Partials     4259     4259           

Flag	Coverage Δ
unittests-datacatalog	51.58% <ø> (ø)
unittests-flyteadmin	54.10% <ø> (+0.02%)	⬆️
unittests-flytecopilot	22.23% <ø> (ø)
unittests-flytectl	62.29% <ø> (ø)
unittests-flyteidl	7.23% <ø> (ø)
unittests-flyteplugins	53.73% <ø> (ø)
unittests-flytepropeller	42.63% <ø> (ø)
unittests-flytestdlib	57.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[welcome]

Congrats on merging your first pull request! 🎉