Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates runllm configuration to use stable channel #5289

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

agiron123
Copy link
Contributor

Tracking issue

N/A

Why are the changes needed?

This PR updates the RunLLM chat widget to use our stable build and also changes the keyboard shortcut to CMD + l so that it does not conflict with Algolia.

By updating to this stable tag, you will now be able to get the latest updates to the RunLLM widget as they are shipped instead of being locked into a particular version.

What changes were proposed in this pull request?

Configuration changes in base.html

How was this patch tested?

Tested by ensuring that the chat widget functions in the preview environment for this PR.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@agiron123 agiron123 force-pushed the runllm-stable-channel branch from 5558a4e to 41e536a Compare April 25, 2024 20:52
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.20%. Comparing base (1f0a4f2) to head (3f60afe).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5289   +/-   ##
=======================================
  Coverage   60.20%   60.20%           
=======================================
  Files         646      646           
  Lines       45654    45654           
=======================================
+ Hits        27486    27487    +1     
+ Misses      15576    15575    -1     
  Partials     2592     2592           
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.82% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.75% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario enabled auto-merge (squash) April 29, 2024 23:40
@eapolinario
Copy link
Contributor

Can you merge master to get rid of the failure in the unit test?

@agiron123 agiron123 requested a review from eapolinario April 29, 2024 23:50
@eapolinario eapolinario merged commit 5470f3f into flyteorg:master Apr 30, 2024
48 checks passed
austin362667 pushed a commit to austin362667/flyte that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants