Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uploading of code coverage data #5298

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Fix uploading of code coverage data #5298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2473c11
Do not upload codecoverage data from boilerplate
eapolinario Apr 29, 2024
88099ff
Use correct token to upload code coverage data
eapolinario Apr 29, 2024
e972f72
Pipe in CODECOV_TOKEN as an input secret
eapolinario Apr 29, 2024
b97b777
Actually pipe the secret in
eapolinario Apr 29, 2024
306afdf
Pipe codecov token in flyteidl tests too
eapolinario Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
component: ${{ matrix.component }}
go-version: ${{ needs.unpack-envvars.outputs.go-version }}
secrets:
FLYTE_BOT_PAT: ${{ secrets.FLYTE_BOT_PAT }}
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
docker-build:
strategy:
fail-fast: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/flyteidl-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
component: flyteidl
go-version: ${{ needs.unpack-envvars.outputs.go-version }}
secrets:
FLYTE_BOT_PAT: ${{ secrets.FLYTE_BOT_PAT }}
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
generate:
name: Check Go Generate
needs:
Expand Down
12 changes: 4 additions & 8 deletions .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
required: true
type: string
secrets:
FLYTE_BOT_PAT:
CODECOV_TOKEN:
required: true
jobs:
tests:
Expand All @@ -27,15 +27,11 @@ jobs:
with:
go-version: ${{ inputs.go-version }}
- name: Unit Tests
env:
GITHUB_TOKEN: ${{ secrets.FLYTE_BOT_PAT }}
run: make install && make test_unit_codecov
# TODO(monorepo): Figure out how to do code coverage aggregation
- name: Push CodeCov
uses: codecov/[email protected]
env:
GITHUB_TOKEN: ${{ secrets.FLYTE_BOT_PAT }}
uses: codecov/codecov-action@v4
with:
file: coverage.txt
flags: unittests
flags: unittests-${{ inputs.component }}
fail_ci_if_error: false
token: ${{ secrets.CODECOV_TOKEN }}
1 change: 0 additions & 1 deletion boilerplate/flyte/golang_test_targets/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ test_unit_visual:
.PHONY: test_unit_codecov
test_unit_codecov:
go test ./... -race -coverprofile=coverage.txt -covermode=atomic
curl -s https://codecov.io/bash > codecov_bash.sh && bash codecov_bash.sh

.PHONY: go-tidy
go-tidy:
Expand Down
Loading