Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Reduce build times by 40% #5328

Merged
merged 1 commit into from
May 6, 2024
Merged

ci: Reduce build times by 40% #5328

merged 1 commit into from
May 6, 2024

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented May 6, 2024

Tracking issue

NA

Why are the changes needed?

we didn't cache Go package in the CI

What changes were proposed in this pull request?

Upgrade setup-go to v4. V4 has enabled caching by default.
https://github.blog/changelog/2023-03-24-github-actions-the-setup-go-action-now-enables-caching-by-default/

How was this patch tested?

CI

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

Signed-off-by: Kevin Su <[email protected]>
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.08%. Comparing base (0a1c82c) to head (f848616).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5328   +/-   ##
=======================================
  Coverage   61.07%   61.08%           
=======================================
  Files         794      794           
  Lines       51203    51203           
=======================================
+ Hits        31271    31276    +5     
+ Misses      17049    17044    -5     
  Partials     2883     2883           
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.82% <ø> (+0.04%) ⬆️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.30% <ø> (ø)
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.73% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw changed the title CI: Reduce build times by 40% ci: Reduce build times by 40% May 6, 2024
@eapolinario
Copy link
Contributor

Amazing. Thank you!

@eapolinario eapolinario merged commit b3c746f into master May 6, 2024
51 checks passed
@eapolinario eapolinario deleted the upgrade-setup-go branch May 6, 2024 15:50
austin362667 pushed a commit to austin362667/flyte that referenced this pull request May 7, 2024
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants