-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve agent plugin documentation with running examples and additional notes #5399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small suggestions, otherwise LGTM!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5399 +/- ##
=======================================
Coverage 36.17% 36.18%
=======================================
Files 1302 1302
Lines 109614 109614
=======================================
+ Hits 39653 39660 +7
+ Misses 65816 65809 -7
Partials 4145 4145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for the review! |
…al notes Signed-off-by: Jason Parraga <[email protected]>
is there a way to re-trigger CI? (besides pushing a new commit) |
@Sovietaced @davidmirror-ops Bumping this -- can you merge |
I recently went through the process of developing an agent plugin by going through the docs. Previously the
developing_agents
documentation had a decent skeleton for the agent example but thelocal_python
documentation had little to no accompanying task example. Its a big confusing because the agent is a stripped down big query agent that is not functional and then later the example task is just a real big query task.Anyhow, I've spent some time updating the documentation to use a completely running agent, task, and example file. Previous agent pseudo code has been commented out and the general workflow has additional comments but there is dummy code that does actually run locally in a manner that someone can start making changes and get feedback immediately to start development.