Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to configure flyte with an externally managed Secret #5700

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mhotan
Copy link
Contributor

@mhotan mhotan commented Aug 28, 2024

  • Make adminOauthClientCredentials secret name configurable.
  • This makes it possible to manage the Kubernetes secret outside the flyte-core helm chart.

Tracking issue

N/A

Why are the changes needed?

Union manages flyte-core helm release via ArgoCD. We identified that managing the oath client secret was appropriate outside of the flyte-core helm release and, thus, outside of a Git repository watched by ArgoCD. This situation will likely surface for other flyte users. We are thus backporting these changes from Union to Flyte OSS.

How was this patch tested?

This change was tested and release to all Union managed data planes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@mhotan mhotan force-pushed the mhotan/configurable-secret-name branch from 75c3fcb to 9b7a65c Compare August 28, 2024 19:31
@mhotan mhotan changed the title Make adminOauthClientCredentials secret name configurable (#417) Make it possible to configure flyte with an externally managed Secret Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.17%. Comparing base (5c147ef) to head (9b7a65c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5700   +/-   ##
=======================================
  Coverage   36.17%   36.17%           
=======================================
  Files        1302     1302           
  Lines      109614   109614           
=======================================
  Hits        39653    39653           
  Misses      65816    65816           
  Partials     4145     4145           
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.30% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.18% <ø> (ø)
unittests-flyteidl 7.12% <ø> (ø)
unittests-flyteplugins 53.34% <ø> (ø)
unittests-flytepropeller 41.71% <ø> (ø)
unittests-flytestdlib 55.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant