[Docs] Update auth_setup.rst #5863
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the following issues: 1. The steps for MS Entra ID have to be updated to reflect the current location of settings on the Azure UI 2. fixed indentation error in ``configmap.adminServer.security`` 3. Step 8 and beyond are folded inside the Note block when it should be out. 4. made the intro slightly easier to read. Signed-off-by: Pranshu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5863 +/- ##
==========================================
- Coverage 36.99% 36.98% -0.01%
==========================================
Files 1318 1318
Lines 132449 132449
==========================================
- Hits 48994 48990 -4
- Misses 79202 79206 +4
Partials 4253 4253
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
thanks for the pr! just one comment and mind updating the conflict? |
Signed-off-by: Pranshu <[email protected]>
wild-endeavor
previously approved these changes
Dec 20, 2024
|
@pranshustuff sorry, mind clearing out the newlines as well please? |
Signed-off-by: Pranshu <[email protected]>
|
@wild-endeavor done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #5552
Why are the changes needed?
The docs had a few issues as mentioned in the issue and the intro was slightly hard to read and understand.
What changes were proposed in this pull request?
configmap.adminServer.securitywas corrected.Check all the applicable boxes
Docs link
Authenticating in Flyte page, changes mentioned above