Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LiteralTypeForLiteral by creating IsInstance function #5909

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

merge upstream

1f58141
Select commit
Loading
Failed to load commit list.
Open

Remove LiteralTypeForLiteral by creating IsInstance function #5909

merge upstream
1f58141
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 20, 2024 in 1s

36.92% (-0.06%) compared to b0062e4, passed because coverage increased by 0% when compared to adjusted base (36.92%)

View this Pull Request on Codecov

36.92% (-0.06%) compared to b0062e4, passed because coverage increased by 0% when compared to adjusted base (36.92%)

Details

Codecov Report

Attention: Patch coverage is 37.77778% with 112 lines in your changes missing coverage. Please review.

Project coverage is 36.92%. Comparing base (b0062e4) to head (1f58141).

Files with missing lines Patch % Lines
flytepropeller/pkg/compiler/validators/utils.go 30.00% 97 Missing and 8 partials ⚠️
...tepropeller/pkg/compiler/errors/compiler_errors.go 0.00% 6 Missing ⚠️
...ytepropeller/pkg/controller/nodes/array/handler.go 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5909      +/-   ##
==========================================
- Coverage   36.97%   36.92%   -0.06%     
==========================================
  Files        1318     1318              
  Lines      132506   132547      +41     
==========================================
- Hits        48994    48942      -52     
- Misses      79256    79345      +89     
- Partials     4256     4260       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.