Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob-storage-usage doc update #5931

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ritesh-Udgata
Copy link

Building the Flyte docs locally

Prerequisites

Set up the build environment

In the flyteorg/flyte root directory do:

$ conda-lock install --name monodocs-env monodocs-environment.lock.yaml
$ conda activate monodocs-env
$ pip install ./flyteidl

This creates a new environment called monodocs-env with all the dependencies needed to build the docs. You can choose a different environment name if you like.

Building the docs

In the flyteorg/flyte root directory make sure you have activated the monodocs-env (or whatever you called it) environment and do:

$ make docs

The resulting html files will be in docs/_build/html.

Closes #4881

Copy link

welcome bot commented Oct 28, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@davidmirror-ops
Copy link
Contributor

@Ritesh-Udgata thank you. Can you clarify if this is connected to an issue?

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.19%. Comparing base (13b3d82) to head (e418732).
Report is 101 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5931       +/-   ##
===========================================
+ Coverage   36.84%   49.19%   +12.35%     
===========================================
  Files        1309      835      -474     
  Lines      130967    72057    -58910     
===========================================
- Hits        48252    35451    -12801     
+ Misses      78531    33414    -45117     
+ Partials     4184     3192      -992     
Flag Coverage Δ
unittests-datacatalog ?
unittests-flyteadmin 54.10% <ø> (-0.02%) ⬇️
unittests-flytecopilot ?
unittests-flytectl ?
unittests-flyteidl ?
unittests-flyteplugins 53.73% <ø> (+0.09%) ⬆️
unittests-flytepropeller 42.63% <ø> (-0.38%) ⬇️
unittests-flytestdlib ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario
Copy link
Contributor

@ppiegaze , can you help investigate the CI failure in test-docs? Do we need to include this new file in some other file?

@davidmirror-ops
Copy link
Contributor

@Ritesh-Udgata can you pleas check the DCO error? steps to sign your commits are here

@Ritesh-Udgata
Copy link
Author

Ritesh-Udgata commented Nov 27, 2024

I have added sign off along with gpg signature to pass the DCO check. Am i eligible for swags ? If so could you reopen the form ? I am asking because this PR was approved two weeks ago approximately and I contributed to the code base during Hacktoberfest time period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved yet unmerged PRs
Development

Successfully merging this pull request may close these issues.

[Docs] Provide documentation on where blob storage is accessed and which keys are being used
4 participants