[COR-1114] Fix token validity check logic to use exp field in access… #5998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…token (#330) * Add logs for token * add logs * Fixing the validity check logic for token * nit * nit * Adding in memory token source provider * nit * changed Valid method to log and ignore parseDateClaim error * nit * Fix unit tests * lint * fix unit tests Signed-off-by: pmahindrakar-oss <[email protected]>
pmahindrakar-oss
force-pushed
the
union/upstream-fa58ba162a5b58cc1498edd6f621a5cb6bce0b6d
branch
from
6fe8e3b to
adc3ce2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5998 +/- ##
==========================================
- Coverage 36.95% 36.93% -0.02%
==========================================
Files 1310 1312 +2
Lines 131451 131502 +51
==========================================
- Hits 48575 48570 -5
- Misses 78655 78712 +57
+ Partials 4221 4220 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: pmahindrakar-oss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… token (#330)
Add logs for token
add logs
Fixing the validity check logic for token
nit
nit
Adding in memory token source provider
nit
changed Valid method to log and ignore parseDateClaim error
nit
Fix unit tests
lint
fix unit tests
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link