Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Enable lint flytecopilot #6003

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

wayner0628
Copy link
Contributor

Tracking issue

#6002

Why are the changes needed?

With recent adjustments to the monorepo structure, the copilot lint check has been temporarily disabled in the CI pipeline. To maintain code quality and consistency, we need to re-enable and verify the copilot linting as part of the CI process.

What changes were proposed in this pull request?

Enable copilot lint check.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@wayner0628
Copy link
Contributor Author

There are some potential lint errors in my previous copilot PR #5715. I'll submit another new PR to address these issues, and we can return to this PR afterward.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.23%. Comparing base (f20b8aa) to head (c73adda).
Report is 3 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (f20b8aa) and HEAD (c73adda). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (f20b8aa) HEAD (c73adda)
unittests-flyteidl 1 0
unittests-datacatalog 1 0
unittests-flytectl 1 0
unittests-flytestdlib 1 0
unittests-flyteplugins 1 0
unittests-flytepropeller 1 0
unittests-flyteadmin 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6003       +/-   ##
===========================================
- Coverage   36.95%   22.23%   -14.73%     
===========================================
  Files        1310        8     -1302     
  Lines      131464      796   -130668     
===========================================
- Hits        48587      177    -48410     
+ Misses      78656      591    -78065     
+ Partials     4221       28     -4193     
Flag Coverage Δ
unittests-datacatalog ?
unittests-flyteadmin ?
unittests-flytecopilot 22.23% <ø> (ø)
unittests-flytectl ?
unittests-flyteidl ?
unittests-flyteplugins ?
unittests-flytepropeller ?
unittests-flytestdlib ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wayner0628
Copy link
Contributor Author

@eapolinario hello, I would like to understand if there are any concerns about leaving the copilot lint check disabled. Thank you!
cc @Future-Outlier

@wayner0628 wayner0628 mentioned this pull request Nov 13, 2024
2 tasks
@eapolinario
Copy link
Contributor

@wayner0628 , no concerns from me, if you want to fix this, by all means go ahead. Thank you!

Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario eapolinario marked this pull request as ready for review November 14, 2024 04:57
@eapolinario eapolinario enabled auto-merge (squash) November 14, 2024 04:57
@eapolinario eapolinario merged commit 3c7b88c into flyteorg:master Nov 14, 2024
50 of 52 checks passed
@wayner0628 wayner0628 deleted the copilot-lint branch November 14, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants