Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update note about Terraform reference implementations #6056

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

davidmirror-ops
Copy link
Contributor

Why are the changes needed?

Updating reference to resources that are already available

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@davidmirror-ops davidmirror-ops changed the title Update reference to Terraform reference implementations Update note about Terraform reference implementations Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.35%. Comparing base (b2759fc) to head (ed25d3a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6056      +/-   ##
==========================================
- Coverage   37.10%   33.35%   -3.75%     
==========================================
  Files        1318     1021     -297     
  Lines      132326   108429   -23897     
==========================================
- Hits        49099    36170   -12929     
+ Misses      78955    69048    -9907     
+ Partials     4272     3211    -1061     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin ?
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (ø)
unittests-flyteidl 7.23% <ø> (ø)
unittests-flyteplugins 53.82% <ø> (ø)
unittests-flytepropeller 42.63% <ø> (ø)
unittests-flytestdlib 57.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidmirror-ops davidmirror-ops merged commit 0585fba into flyteorg:master Nov 28, 2024
50 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant