Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass CustomInfo metadata through ArrayNode ExternalResourceInfo (#591) #6116

Merged

Conversation

hamersaw
Copy link
Contributor

Tracking issue

N/A

Why are the changes needed?

Passes CustomInfo from ExternalResourceInfo through ArrayNode subNode executions.

What changes were proposed in this pull request?

^^^

How was this patch tested?

Tested locally.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

N/A

Docs link

N/A

* pass CustomInfo through ArrayNode event recorder

Signed-off-by: Daniel Rammer <[email protected]>

* actually doing it

Signed-off-by: Daniel Rammer <[email protected]>

* correctly passing custom

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
@hamersaw hamersaw requested a review from eapolinario December 18, 2024 17:16
@hamersaw hamersaw changed the title Pass Actor metadata through ArrayNode ExternalResourceInfo (#591) Pass CustomInfo metadata through ArrayNode ExternalResourceInfo (#591) Dec 18, 2024
Signed-off-by: Daniel Rammer <[email protected]>
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.98%. Comparing base (3c03cff) to head (d653b15).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...eller/pkg/controller/nodes/array/event_recorder.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6116      +/-   ##
==========================================
- Coverage   36.98%   36.98%   -0.01%     
==========================================
  Files        1318     1318              
  Lines      132473   132480       +7     
==========================================
- Hits        48994    48992       -2     
- Misses      79225    79232       +7     
- Partials     4254     4256       +2     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.03% <ø> (-0.03%) ⬇️
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.33% <ø> (+0.04%) ⬆️
unittests-flyteidl 7.24% <ø> (ø)
unittests-flyteplugins 53.85% <ø> (-0.01%) ⬇️
unittests-flytepropeller 42.60% <62.50%> (+<0.01%) ⬆️
unittests-flytestdlib 55.13% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pvditt
pvditt previously approved these changes Dec 19, 2024
eapolinario
eapolinario previously approved these changes Dec 19, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario eapolinario dismissed stale reviews from pvditt and themself via d653b15 December 19, 2024 19:14
@eapolinario eapolinario enabled auto-merge (squash) December 19, 2024 19:15
@eapolinario eapolinario merged commit b0062e4 into master Dec 19, 2024
51 of 52 checks passed
@eapolinario eapolinario deleted the union/upstream-cf28ae7e094d9082c415e250db58ae84e7b77409 branch December 19, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants