Fix: Fix deprecated numpy type and make numpy<2 explicit dependency #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 16, 2024 17:51
Signed-off-by: Fabio Grätz <[email protected]>
Signed-off-by: Fabio Grätz <[email protected]>
fg91
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
3 tasks
Signed-off-by: Fabio Grätz <[email protected]>
fg91
changed the title
cosmicBboy
approved these changes
Jun 17, 2024
2 tasks
bgedik
pushed a commit
to bgedik/flytekit
that referenced
this pull request
Jul 3, 2024
…lyteorg#2483) * Replace deprecated np.string_ with np.bytes_ (alias) Signed-off-by: Fabio Grätz <[email protected]> * Make numpy an explicit dependency Signed-off-by: Fabio Grätz <[email protected]> * Pin numpy to <2 Signed-off-by: Fabio Grätz <[email protected]> --------- Signed-off-by: Fabio Grätz <[email protected]> Co-authored-by: Fabio Grätz <[email protected]> Signed-off-by: bugra.gedik <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
…2483) * Replace deprecated np.string_ with np.bytes_ (alias) Signed-off-by: Fabio Grätz <[email protected]> * Make numpy an explicit dependency Signed-off-by: Fabio Grätz <[email protected]> * Pin numpy to <2 Signed-off-by: Fabio Grätz <[email protected]> --------- Signed-off-by: Fabio Grätz <[email protected]> Co-authored-by: Fabio Grätz <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Today,
numpy==2.0.0was released. This new release broke the sandbox-bundled-functional-tests in flyteorg/flyte#4726:The docs of numpy 1.26 also show that
string_is just an alias tobytes_.I noticed that numpy isn't an explicit flytekit dependency even though flytekit imports numpy. I fix this as well and pin numpy to <2 for now as CI jobs of several plugins fail with numpy errors currently.