[BUG] Support creation and reading of StructuredDataset with local or remote uri #2914
+82
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JiaWei Jiang <[email protected]>
Open
2 tasks
Signed-off-by: JiaWei Jiang <[email protected]>
Signed-off-by: JiaWei Jiang <[email protected]>
JiangJiaWei1103
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
JiangJiaWei1103
changed the title
JiangJiaWei1103
changed the title
|
this is awesome |
Comment on lines
+187
to
+200
| def _set_literal(self, ctx: FlyteContext, expected: LiteralType) -> None: | ||
| """ | ||
| Explicitly set the StructuredDataset Literal to handle the following cases: | ||
|
|
||
| 1. Read a dataframe from a StructuredDataset with an uri, for example: | ||
|
|
||
| @task | ||
| def return_sd() -> StructuredDataset: | ||
| sd = StructuredDataset(uri="s3://my-s3-bucket/s3_flyte_dir/df.parquet", file_format="parquet") | ||
| df = sd.open(pd.DataFrame).all() | ||
| return df | ||
|
|
||
| For details, please refer to this issue: https://github.com/flyteorg/flyte/issues/5954. | ||
| """ |
Comment on lines
+201
to
+202
| to_literal = loop_manager.synced(flyte_dataset_transformer.async_to_literal) | ||
| self._literal_sd = to_literal(ctx, self, StructuredDataset, expected).scalar.structured_dataset |
There was a problem hiding this comment.
Not sure if is here the best way to write it.
cc @wild-endeavor @thomasjpfan
Comment on lines
+668
to
+684
| @task | ||
| def upload_pqt_to_s3(local_path: str, remote_path: str) -> None: | ||
| """Upload local temp parquet file to s3 object storage""" | ||
| with tempfile.TemporaryDirectory() as tmp_dir: | ||
| fs = FileAccessProvider( | ||
| local_sandbox_dir=tmp_dir, | ||
| raw_output_prefix="s3://my-s3-bucket" | ||
| ) | ||
| fs.upload(local_path, remote_path) | ||
|
|
||
| @task | ||
| def read_sd_from_uri(uri: str) -> pd.DataFrame: | ||
| sd = StructuredDataset(uri=uri, file_format="parquet") | ||
| df = sd.open(pd.DataFrame).all() | ||
|
|
||
| return df | ||
|
|
There was a problem hiding this comment.
Hi, @JiangJiaWei1103
you should put these tasks in a workflow,
which is closer to the reality that users use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #5954.
Why are the changes needed?
When
StructuredDatasetis instantiated with anuri, the operation of directly reading the dataframe fails. There exist two cases to discuss:StructuredDatasetwith a local file path asuri:StructuredDatasetwith a remote file path (e.g., s3 object storage) asuri:Both cases should successfully read and return
pd.DataFrame.What changes were proposed in this pull request?
As commented here, users have no options to set
_literal_sdinStructuredDataset. To prevent_literal_sdfrom beingNoneType, we useStructuredDatasetTransformerEngineto construct aStructuredDatasetliteral and assign it to_literal_sdofStructuredDatasettype.How was this patch tested?
This patch is tested through a newly added unit test.
Setup process
Check all the applicable boxes
Related PRs
Docs link