Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Hello World" Flytekit Tutorial Code #1170

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Fix "Hello World" Flytekit Tutorial Code #1170

merged 3 commits into from
Oct 10, 2023

Conversation

rachfop
Copy link
Contributor

@rachfop rachfop commented Oct 5, 2023

Description

This PR addresses an issue in the "Hello World" tutorial for Flytekit:

The workflow was named hello_world_wf, but the main execution block tried to run an undeclared my_wf().
This has been corrected to run hello_world_wf().

With this corrections, the tutorial code now runs successfully.

Changes

  • Fixed the name mismatch in the main execution block.

Testing

Ensure the tutorial runs without any issues after applying these changes.

python hello_world.py
╭─ Traceback (most recent call ─╮
│ /Users/flytectl/docs/ │
│ hello_world.py:13 in <module> │
│                               │
│ ❱ 13 │   print(f"Running my_w │
╰───────────────────────────────╯
NameError: name 'my_wf' is not 

The `my_wf` is never declared.
Fixed that and a few other small things to get this hello world tutoiral to run.

Signed-off-by: Patrick Rachford <[email protected]>
@pingsutw pingsutw merged commit 82e4777 into flyteorg:master Oct 10, 2023
3 checks passed
@rachfop rachfop deleted the patch-1 branch October 10, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants