Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chatgpt Agent Example #1539

Merged
merged 31 commits into from
Mar 6, 2024
Merged

Chatgpt Agent Example #1539

merged 31 commits into from
Mar 6, 2024

Conversation

@Future-Outlier
Copy link
Member Author

@neverett , @pingsutw
If possible please help review, and feel free to ping me, I will update it as soon as possible, thank you all!

@Future-Outlier
Copy link
Member Author

I am not sure whether should I provide the Dockerfile since the chatgpt agent hasn't been released in flytekit.
Also, the example of it doesn't need the Dockerfile unless we run a pod task in the file.

@@ -331,7 +331,7 @@ documentation.
Verify that the code and documentation look as expected:

- Learn about the documentation tools [here](https://docs.flyte.org/en/latest/community/contribute.html#documentation)
- Install the requirements by running `pip install -r docs-requirements.txt`.
- Install the requirements by running `pip install -r docs-requirements.in`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we change it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I am using python3.9 to develop, use pip install -r docs-requirements.txt will have the error below.
However, use pip install -r docs-requirements.in can solve the case.
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be resolved by running pip-compile docs-requirements.in first, then pip install -r requirements.txt?

Copy link
Member Author

@Future-Outlier Future-Outlier Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my case, the docs-requirements.txt is generated by python3.11.
I use python 3.9 and the error says that some modules required python>=3.10.
So I just install docs-requirements.in instead.

Do you mean

  1. pip-compile docs-requirements.in
  2. pip install -r docs-requirements.txt
    compile it again, and install it?
    I think it might work, too, but installing docs-requirements.in will give us more flexibility to support all python versions, at least from python3.8 to python3.12.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will want to resolve this in a separate PR so it doesn't block merging the ChatGPT example and updates to the other agent examples. @Future-Outlier would you be able to undo this change in this branch and create a separate branch and PR for it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, thank you!

@@ -331,7 +331,7 @@ documentation.
Verify that the code and documentation look as expected:

- Learn about the documentation tools [here](https://docs.flyte.org/en/latest/community/contribute.html#documentation)
- Install the requirements by running `pip install -r docs-requirements.txt`.
- Install the requirements by running `pip install -r docs-requirements.in`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be resolved by running pip-compile docs-requirements.in first, then pip install -r requirements.txt?

docs/sg_execution_times.rst Outdated Show resolved Hide resolved
examples/chatgpt_agent/README.md Outdated Show resolved Hide resolved
examples/databricks_agent/README.md Outdated Show resolved Hide resolved
examples/mmcloud_agent/README.md Outdated Show resolved Hide resolved
examples/snowflake_agent/README.md Outdated Show resolved Hide resolved
examples/bigquery_agent/README.md Outdated Show resolved Hide resolved
@Future-Outlier Future-Outlier requested a review from neverett March 5, 2024 05:58
Future-Outlier and others added 22 commits March 6, 2024 08:38
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
…ge.py

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
…ge.py

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
…ge.py

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
…ge.py

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
…ge.py

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
…ge.py

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
…ge.py

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
…ge.py

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
…ge.py

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
…ge.py

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
…ge.py

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
…ge.py

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
…ge.py

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Future-Outlier and others added 9 commits March 6, 2024 08:38
…ge.py

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier Future-Outlier force-pushed the chatgpt_agent_example branch from 1557f2b to b9f28bf Compare March 6, 2024 00:43
@neverett neverett merged commit 2b66aa9 into master Mar 6, 2024
100 checks passed
@neverett neverett deleted the chatgpt_agent_example branch March 6, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants