-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up and move user guide Python files #1584
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
… build Signed-off-by: nikki everett <[email protected]>
…mple_code Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
2 tasks
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
neverett
changed the title
Clean up user guide example code
Clean up and move user guide example code
Apr 10, 2024
neverett
changed the title
Clean up and move user guide example code
Clean up and move user guide Python files
Apr 10, 2024
Signed-off-by: nikki everett <[email protected]>
ppiegaze
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
example_code
directory so they don't get consumed by the docs build process..flake
config file to ignoreE402 module level import not at top of file
errors because many of the user guide Python files contain multiple examples with multiple imports at different places in the file. I think the reason these errors didn't come up when the files lived in theexamples
directory was because they were processed by the auto_examples custom extension and not linted as Python files.After this PR is merged, I will replace the embedded code snippets in the user guide Markdown docs in the Flyte repo with
rli
(remoteliteralinclude) directives that reference the user guide Python files in this repo. (See flyteorg/flyte#5207).