Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add time series tutorial #1738

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add time series tutorial #1738

wants to merge 2 commits into from

Conversation

cosmicBboy
Copy link
Contributor

This PR adds a time-series modeling tutorial to the flyte docs

Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Copy link
Contributor

@neverett neverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, otherwise LGTM!

model_file.download()
model = load(model_file.path)

# Create a new dataframe reaching 365 into the future
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Create a new dataframe reaching 365 into the future
# Create a new dataframe reaching 365 days into the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants