Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a new page in Integrations section for Pydantic plugin in Flyte documentation #1757

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sumana-2705
Copy link
Contributor

Description:

This pull request adds a new example demonstrating the integration of Pydantic with Flytekit. This PR closes issue

Changes:

  • New Example Directory: Added a new directory pydantic_plugin under examples to host the Pydantic integration example.
  • Dockerfile: Included a Dockerfile for the example to facilitate containerized execution.
  • Requirements: Created a requirements.in file specifying the necessary dependencies.
  • Example Code: Added pydantic_integration_example.py demonstrating how to define and use Pydantic models in Flyte tasks and workflows.
  • Documentation: Included a README.md file with a detailed introduction to Pydantic, installation instructions, and example usage.

Signed-off-by: sumana sree <[email protected]>
@sumana-2705
Copy link
Contributor Author

@davidmirror-ops

can you please explain me what should be done to avoid errors?

Comment on lines +6 to +8
# Pydantic is a data validation and settings management library for Python, enabling the creation of data models with type annotations.
#
# Flyte leverages Pydantic for robust input validation and serialization, ensuring that task inputs are correctly structured.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems repetitive. also, can you come up with a better example? something that solves a use case. needn't be complex, but must solve a problem. does that make sense?


from flytekit import task, workflow
from flytekit.types.file import FlyteFile
from pydantic.v1 import BaseModel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pydantic v2 should work: flyteorg/flytekit#2217

could you run this workflow on Union serverless/flyte sandbox and share with us the result of the execution?

Copy link
Contributor Author

@sumana-2705 sumana-2705 Oct 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samhita-alla I am currently experiencing difficulties while executing my code on the Union serverless/Flyte sandbox. Specifically, I have encountered errors related to importing the BaseModel from the Pydantic library.

  1. When attempting to execute the following code:
    from pydantic.v1 import BaseModel

I got this error:
Screenshot 2024-10-26 114446

  1. When I tried this:
    from pydantic import BaseModel

I got this error:
Screenshot 2024-10-26 114642

I am not able to understand how to avoid these errors. How to resolve these errors?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@sumana-2705 sumana-2705 Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidmirror-ops
Copy link
Contributor

@ppiegaze do you have an idea of why the test failure here? It's like it's checking for the existence of a page that's just being created?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] pydantic integration: create flytesnacks example page
3 participants