This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Extract CatalogClient from flytepropeller to flytestdlib #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
- Coverage 67.94% 67.45% -0.50%
==========================================
Files 69 75 +6
Lines 4077 4756 +679
==========================================
+ Hits 2770 3208 +438
- Misses 1148 1348 +200
- Partials 159 200 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
8 tasks
Implemented new datacatalog functionality required for cache eviction Updated to latest unreleased version of flyteidl and flyteplugins Signed-off-by: Nick Müller <[email protected]>
MorpheusXAUT
force-pushed
the
delete-artifact
branch
from
ded77ff
to
9b16556
Compare
8 tasks
Signed-off-by: Nick Müller <[email protected]>
MorpheusXAUT
force-pushed
the
delete-artifact
branch
from
4f21d00
to
d6ec6db
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
The
CatalogClientimplementation has been extracted from flytepropeller's source code and moved to flytestdlib as flyteadmin also needs access to the functionality.Type
Are all requirements met?
Complete description
The whole latest implementation of the
catalogpackage was moved from flytepropeller to here since flyteadmin will need access to a client interacting with datacatalog for evicting cached executions.Additionally, the new functionality for acquiring/releasing reservations via artifact tag as well as the deletion of artifacts was implemented for the datacatalog client.
The PR was created as a draft until the flyteidl and flyteplugins PRs have been merged and respective versions have been published.
Tracking Issue
flyteorg/flyte#2867
Follow-up issue
NA