Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CaFormatExcludeFile flag to catar archives #116

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Conversation

folbricht
Copy link
Owner

This adds CaFormatExcludeFile to feature flags as per #114. The catar flags produced for both are now: 0xb000000010001f22.

@tomberek
Copy link

Not sure if this should be added if the feature doesn't actually exist in desync. Or does it?

@folbricht
Copy link
Owner Author

I'm not even sure what that flag exactly means and why it's added to archives by casync.

@tomberek
Copy link

tomberek commented Aug 11, 2019

It it similar to .gitignore. Allows you to exclude files from a directory tree. See documentation at the end of https://github.com/systemd/casync/blob/master/doc/casync.rst

(at least i presume that the flag refers to this)

@folbricht
Copy link
Owner Author

That flag seems to refer more to a capability of the tool that produced the archive, not something the archive itself needs to know. casync adds that even without actually excluding files. So no, desync doesn't currently support this, but I'm ok adding it if that aligns better with casync.

@tomberek
Copy link

Let's leave the issue open to add the capability in the future, but merge this to get closer for reproducibility/testing?

@folbricht folbricht merged commit 74e3261 into master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants