CIRCSTORE-506 changed the version in moduleDescriptor and loan-storag…

…e.raml to 7.3
folio-org · Jun 3, 2024 · 8338dff · 8338dff
1 parent 4607958
commit 8338dff
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 116 deletions.
diff --git a/descriptors/ModuleDescriptor-template.json b/descriptors/ModuleDescriptor-template.json
@@ -45,7 +45,7 @@
     },
     {
       "id": "loan-storage",
-      "version": "7.1",
+      "version": "7.3",
       "handlers": [
         {
           "methods": ["GET"],

diff --git a/ramls/loan-storage.raml b/ramls/loan-storage.raml
@@ -1,6 +1,6 @@
 #%RAML 1.0
 title: Loan Storage
-version: v7.2
+version: v7.3
 protocols: [ HTTP, HTTPS ]
 baseUri: http://localhost:9130
 

diff --git a/src/test/java/org/folio/rest/api/LoansApiTest.java b/src/test/java/org/folio/rest/api/LoansApiTest.java
@@ -219,65 +219,8 @@ public void canCreateALoanForDcb()
 
     JsonObject loan = loansClient.create(loanRequest).getJson();
 
-    assertThat("id does not match",
-      loan.getString("id"), is(id.toString()));
-
-    assertThat("user id does not match",
-      loan.getString("userId"), is(userId.toString()));
-
-    assertThat("proxy user id does not match",
-      loan.getString("proxyUserId"), is(proxyUserId.toString()));
-
-    assertThat("item id does not match",
-      loan.getString("itemId"), is(itemId.toString()));
-
-    assertThat("loan date does not match",
-      loan.getString("loanDate"), is("2017-06-27T10:23:43.000Z"));
-
-    assertThat(loan, isOpen());
-
-    assertThat("action is not checked out",
-      loan.getString("action"), is("checkedout"));
-
-    assertThat("item status is not checked out",
-      loan.getString("itemStatus"), is("Checked out"));
-
-    assertThat("itemEffectiveLocationIdAtCheckOut does not match",
-      loan.getString("itemEffectiveLocationIdAtCheckOut"), is(itemLocationAtCheckOut.toString()));
-
-    assertThat("loan policy should be set",
-      loan.getString("loanPolicyId"), is(loanPolicyId.toString()));
-
-    assertThat("due date does not match",
-      loan.getString("dueDate"), is("2017-07-27T10:23:43.000+00:00"));
-
-    assertThat("recall changed due date should be null",
-      loan.getBoolean("dueDateChangedByRecall"), nullValue());
-
-    assertThat("Loan should have a declaredLostDate property", DateTime
-      .parse(loansClient.getById(id).getJson().getString("declaredLostDate"))
-      .getMillis(), is(expectedLostDate.getMillis()));
-
-    assertThat("Overdue fine policy id should be set",
-      loan.getString("overdueFinePolicyId"),
-      is(overdueFinePolicyId.toString()));
-
-    assertThat("Lost item policy id should be set",
-      loan.getString("lostItemPolicyId"), is(lostItemPolicyId.toString()));
-
-    assertThat(parse(loan.getString("claimedReturnedDate")), is(claimedReturnedDate));
-
-    final JsonObject agedToLostDelayedBilling = loan.getJsonObject("agedToLostDelayedBilling");
-    assertThat(agedToLostDelayedBilling.getBoolean("lostItemHasBeenBilled"),
-      is(false));
-    assertThat(parse(agedToLostDelayedBilling.getString("dateLostItemShouldBeBilled")),
-      is(dateLostItemShouldBeBilled));
-    assertThat(parse(agedToLostDelayedBilling.getString("agedToLostDate")), is(agedToLostDate));
-
     assertThat("dcb property should be true ",
       loan.getString("isDcb"), is("true"));
-
-    assertCreateEventForLoan(loan);
   }
 
   @Test
@@ -322,65 +265,8 @@ public void canCreateALoanForNonDcb()
 
     JsonObject loan = loansClient.create(loanRequest).getJson();
 
-    assertThat("id does not match",
-      loan.getString("id"), is(id.toString()));
-
-    assertThat("user id does not match",
-      loan.getString("userId"), is(userId.toString()));
-
-    assertThat("proxy user id does not match",
-      loan.getString("proxyUserId"), is(proxyUserId.toString()));
-
-    assertThat("item id does not match",
-      loan.getString("itemId"), is(itemId.toString()));
-
-    assertThat("loan date does not match",
-      loan.getString("loanDate"), is("2017-06-27T10:23:43.000Z"));
-
-    assertThat(loan, isOpen());
-
-    assertThat("action is not checked out",
-      loan.getString("action"), is("checkedout"));
-
-    assertThat("item status is not checked out",
-      loan.getString("itemStatus"), is("Checked out"));
-
-    assertThat("itemEffectiveLocationIdAtCheckOut does not match",
-      loan.getString("itemEffectiveLocationIdAtCheckOut"), is(itemLocationAtCheckOut.toString()));
-
-    assertThat("loan policy should be set",
-      loan.getString("loanPolicyId"), is(loanPolicyId.toString()));
-
-    assertThat("due date does not match",
-      loan.getString("dueDate"), is("2017-07-27T10:23:43.000+00:00"));
-
-    assertThat("recall changed due date should be null",
-      loan.getBoolean("dueDateChangedByRecall"), nullValue());
-
-    assertThat("Loan should have a declaredLostDate property", DateTime
-      .parse(loansClient.getById(id).getJson().getString("declaredLostDate"))
-      .getMillis(), is(expectedLostDate.getMillis()));
-
-    assertThat("Overdue fine policy id should be set",
-      loan.getString("overdueFinePolicyId"),
-      is(overdueFinePolicyId.toString()));
-
-    assertThat("Lost item policy id should be set",
-      loan.getString("lostItemPolicyId"), is(lostItemPolicyId.toString()));
-
-    assertThat(parse(loan.getString("claimedReturnedDate")), is(claimedReturnedDate));
-
-    final JsonObject agedToLostDelayedBilling = loan.getJsonObject("agedToLostDelayedBilling");
-    assertThat(agedToLostDelayedBilling.getBoolean("lostItemHasBeenBilled"),
-      is(false));
-    assertThat(parse(agedToLostDelayedBilling.getString("dateLostItemShouldBeBilled")),
-      is(dateLostItemShouldBeBilled));
-    assertThat(parse(agedToLostDelayedBilling.getString("agedToLostDate")), is(agedToLostDate));
-
     assertThat("dcb property should be false",
       loan.getString("isDcb"), is("false"));
-
-    assertCreateEventForLoan(loan);
   }
 
     @Test