Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODEXPW-499: Replace deprecated KafkaProperties methods #560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

julianladisch
Copy link
Contributor

https://folio-org.atlassian.net/browse/MODEXPW-499

Spring’s KafkaProperties.buildConsumerProperties() and KafkaProperties.buildProducerProperties() have been removed for Spring Boot 3.4.0 after they had been deprecated since Spring Boot 3.2.0:

spring-projects/spring-boot@375b3b1#diff-404dc03ddacbc84d318f540f121b6d27b94d0237bad511d61f6f65357f659f28

The old code and the intended replacements are KafkaProperties.buildConsumerProperties(null) and KafkaProperties.buildProducerProperties(null).

Purpose

Replace deprecated KafkaProperties methods that no longer exist in Spring Boot 3.4.0.

Approach

Replace the zero argument method with the single argument method passing null.

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • Check logging
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added, or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

https://folio-org.atlassian.net/browse/MODEXPW-499

Spring’s KafkaProperties.buildConsumerProperties() and KafkaProperties.buildProducerProperties() have been removed for Spring Boot 3.4.0 after they had been deprecated since Spring Boot 3.2.0:

spring-projects/spring-boot@375b3b1#diff-404dc03ddacbc84d318f540f121b6d27b94d0237bad511d61f6f65357f659f28

The old code and the intended replacements are KafkaProperties.buildConsumerProperties(null) and KafkaProperties.buildProducerProperties(null).
@julianladisch julianladisch requested a review from a team August 13, 2024 11:19
Copy link

sonarcloud bot commented Aug 15, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant