Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(browse-classification): prepare and populate database for classification browse #514

Merged
merged 2 commits into from
Feb 12, 2024
Merged

feat(browse-classification): prepare and populate database for classification browse #514

merged 2 commits into from
Feb 12, 2024

Conversation

psmagin
Copy link
Contributor

@psmagin psmagin commented Feb 8, 2024 •
edited
Loading

Purpose

Prepare and populate database for classification browse

Approach

  • prepare database scripts for new table creation
  • create pre-processor for instances to populdate the table with classifications (it should be used then to convert database records to elastic documents)
  • replace folio-service-tools wtih folio-spring-testing that causes a lot of import changes.

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

https://folio-org.atlassian.net/browse/MSEARCH-667

@psmagin psmagin force-pushed the MSEARCH-667 branch 2 times, most recently from 597160d to 41be78b Compare February 9, 2024 10:11
@psmagin
feat(browse-classification): prepare and populate database for classi…
f3a56cb 
…fication browse

Closes: MSEARCH-667
Signed-off-by: psmagin <[email protected]>
@psmagin psmagin self-assigned this Feb 9, 2024
@psmagin psmagin marked this pull request as ready for review February 9, 2024 13:57
@psmagin psmagin requested a review from a team as a code owner February 9, 2024 13:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
88.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@psmagin psmagin merged commit 13c66d9 into master Feb 12, 2024
6 checks passed
@psmagin psmagin deleted the MSEARCH-667 branch February 12, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viacheslavkol viacheslavkol viacheslavkol left review comments

@mukhiddin-yusuf mukhiddin-yusuf mukhiddin-yusuf approved these changes

@TsaghikKhachatryan TsaghikKhachatryan TsaghikKhachatryan approved these changes

@GeloPakDev1 GeloPakDev1 Awaiting requested review from GeloPakDev1 GeloPakDev1 is a code owner automatically assigned from folio-org/spitfire-backend

Assignees

@psmagin psmagin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@psmagin @TsaghikKhachatryan @viacheslavkol @mukhiddin-yusuf