Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(browse-classifications): implement browse config management endpoints #521

Merged
merged 2 commits into from
Feb 23, 2024
Merged

fix(browse-classifications): implement browse config management endpoints #521

merged 2 commits into from
Feb 23, 2024

Conversation

psmagin
Copy link
Contributor

@psmagin psmagin commented Feb 22, 2024 •
edited
Loading

Purpose

Implement browse config management endpoints

Approach

  • API defined
  • implementation for API provided

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

https://issues.folio.org/browse/MSEARCH-674

@psmagin psmagin marked this pull request as ready for review February 22, 2024 14:59
@psmagin psmagin requested a review from a team as a code owner February 22, 2024 14:59
@psmagin psmagin self-assigned this Feb 22, 2024
@psmagin psmagin changed the title fix(browse-classifications): implement browse config endpoint fix(browse-classifications): implement browse config management endpoints Feb 22, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@psmagin psmagin merged commit 947daea into master Feb 23, 2024
6 checks passed
@psmagin psmagin deleted the MSEARCH-674 branch February 23, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeloPakDev1 GeloPakDev1 GeloPakDev1 approved these changes

@mukhiddin-yusuf mukhiddin-yusuf mukhiddin-yusuf approved these changes

@viacheslavkol viacheslavkol viacheslavkol approved these changes

@TsaghikKhachatryan TsaghikKhachatryan Awaiting requested review from TsaghikKhachatryan TsaghikKhachatryan is a code owner automatically assigned from folio-org/spitfire-backend

@viacheslavpoliakov viacheslavpoliakov Awaiting requested review from viacheslavpoliakov viacheslavpoliakov is a code owner automatically assigned from folio-org/spitfire-backend

Assignees

@psmagin psmagin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@psmagin @viacheslavkol @mukhiddin-yusuf @GeloPakDev1