Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search-instances): implement endpoint for consolidate items access in consortium #539

Merged
merged 5 commits into from
Mar 15, 2024
Merged

feat(search-instances): implement endpoint for consolidate items access in consortium #539

merged 5 commits into from
Mar 15, 2024

Conversation

psmagin
Copy link
Contributor

@psmagin psmagin commented Mar 14, 2024 •
edited
Loading

Purpose

implement endpoint for consolidate items access in consortium

Approach

  • Define new API endpoint
  • Implement logic for item fetching

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

https://folio-org.atlassian.net/browse/MSEARCH-693

psmagin added 2 commits March 14, 2024 16:02
@psmagin
feat(search-instances): implement endpoint for consolidate items acce…
77f740d 
…ss in consortium (#535)

Closes: MSEARCH-693
Signed-off-by: psmagin <[email protected]>
@psmagin
- fix tests
256335f 
Signed-off-by: psmagin <[email protected]>
@psmagin psmagin changed the title feat(search-instances): implement endpoint for consolidate items acce… feat(search-instances): implement endpoint for consolidate items access in consortium Mar 14, 2024
@psmagin psmagin self-assigned this Mar 14, 2024
@psmagin
- fix test data
dcc6d78 
Signed-off-by: psmagin <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@psmagin psmagin marked this pull request as ready for review March 14, 2024 19:58
@psmagin psmagin requested a review from a team as a code owner March 14, 2024 19:58
@psmagin psmagin merged commit 1a65a74 into master Mar 15, 2024
6 checks passed
@psmagin psmagin deleted the MSEARCH-693 branch March 15, 2024 11:48
psmagin added a commit that referenced this pull request Mar 18, 2024
@psmagin
feat(search-instances): implement endpoint for consolidate items acce…
3db6940 
…ss in consortium (#539)

Closes: MSEARCH-693

(cherry picked from commit 1a65a74)
Signed-off-by: psmagin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viacheslavpoliakov viacheslavpoliakov viacheslavpoliakov approved these changes

@viacheslavkol viacheslavkol viacheslavkol approved these changes

@TsaghikKhachatryan TsaghikKhachatryan Awaiting requested review from TsaghikKhachatryan TsaghikKhachatryan is a code owner automatically assigned from folio-org/spitfire-backend

@mukhiddin-yusuf mukhiddin-yusuf Awaiting requested review from mukhiddin-yusuf mukhiddin-yusuf is a code owner automatically assigned from folio-org/spitfire-backend

@GeloPakDev1 GeloPakDev1 Awaiting requested review from GeloPakDev1 GeloPakDev1 is a code owner automatically assigned from folio-org/spitfire-backend

Assignees

@psmagin psmagin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psmagin @viacheslavkol @viacheslavpoliakov