Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search-instances): Fix range query convertions when other filters present #683

Merged
merged 2 commits into from
Oct 21, 2024
Merged

fix(search-instances): Fix range query convertions when other filters present #683

merged 2 commits into from
Oct 21, 2024

Conversation

viacheslavkol
Copy link
Contributor

@viacheslavkol viacheslavkol commented Oct 18, 2024 •
edited
Loading

Purpose

Fix range query convertions when other filters present

Approach

Move range query collapsing on the latest stage of conversion, iterate through all range queries to find ones suitable for collapsing

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

MSEARCH-845

@viacheslavkol viacheslavkol self-assigned this Oct 18, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@viacheslavkol viacheslavkol marked this pull request as ready for review October 18, 2024 12:15
@viacheslavkol viacheslavkol requested a review from a team as a code owner October 18, 2024 12:15
@viacheslavkol viacheslavkol merged commit c605355 into master Oct 21, 2024
6 checks passed
@viacheslavkol viacheslavkol deleted the MSEARCH-845-fix branch October 21, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SvitlanaKovalova1 SvitlanaKovalova1 SvitlanaKovalova1 approved these changes

@psmagin psmagin psmagin approved these changes

@mukhiddin-yusuf mukhiddin-yusuf Awaiting requested review from mukhiddin-yusuf mukhiddin-yusuf is a code owner automatically assigned from folio-org/spitfire-backend

Assignees

@viacheslavkol viacheslavkol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viacheslavkol @psmagin @SvitlanaKovalova1