Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (linked-data): Use 'lccnSearchTermProcessor' in linked-data search APIs #728

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

pkjacob
Copy link
Contributor

@pkjacob pkjacob commented Jan 6, 2025

Purpose

At present, the LCCN search term passed in linked-data search queries are not normalized before executing the open search query. As a result, the search results are not returned correctly.
This change update GET search/linked-data/*** APIs to use 'lccnSearchTermProcessor' .

Approach

Use 'lccnSearchTermProcessor' in linked-data search APIs

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • [] Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

MSEARCH-935

@pkjacob pkjacob force-pushed the pjacob/MSEARCH-935 branch from 5f8a5f4 to 7c06697 Compare January 7, 2025 14:42
@pkjacob pkjacob force-pushed the pjacob/MSEARCH-935 branch from 7c06697 to fed4127 Compare January 7, 2025 16:08
Copy link

sonarqubecloud bot commented Jan 7, 2025

@pkjacob pkjacob merged commit b58e2f6 into master Jan 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants