Skip to content

Commit

Permalink
Add @jridgewell/gen-mapping and @types/react to package.json
Browse files Browse the repository at this point in the history
  • Loading branch information
@dmoroz-ebsco
dmoroz-ebsco committed Dec 11, 2024
1 parent 19c08f8 commit 327b692
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@
"lodash": "^4.17.5"
},
"resolutions": {
"@jridgewell/gen-mapping": "0.3.7",
"@types/react": "^18",
"@folio/stripes-template-editor": "v3.3.4",
"typescript": "~5.5",
"@rehooks/local-storage": "2.4.5",
Expand Down

1 comment on commit 327b692

@zburke
Copy link
Member

@zburke zburke commented on 327b692 Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmoroz-ebsco, please help me understand where these changes came from. There is no affiliated pull-request or explanatory comment describing why these changes are necessary. git diff has already told us the "what"; we need the comment to tell us the "why".

I authored the PR adding a resolution for @types/react to the snapshot branch. It was necessary there because yarn.lock is continually rebuilt from scratch. But here we are not rebuilding yarn.lock from scratch, so I would not expect this version to leak unless we failed to implement FOLIO-3768 correctly.

I do not have any context for adding a resolution for @jridgewell/gen-mapping although reading through the issue history shows a bunch of churn there, which this may be a reaction to. Can you confirm this, and describe behavior led you to adding this resolution? That said, again, this should not be necessary on a release branch unless we failed to implement FOLIO-3768 correctly.

Please sign in to comment.