Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove frontend AST pattern matching (WIP) #3132

Merged
merged 22 commits into from
Jan 17, 2025

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Jan 3, 2025

This will remove the lezer_template pattern matching system (#1849): it has become unmaintainable and the advantage is not toooo big. This will unblock #2980 . The new parser in #2980 is also much more "verbose", so implementing the same functionality with standard TreeCursor API becomes simpler.

Changes

The lezer_template` pattern matching was removed

The scope merging system was removed

pkg_bubble_plugin.js rewritten based on TreeCursor.

scopestate_statefield.js rewritten based on TreeCursor. The new version is less precise, but much smaller.

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="remove-ast-pattern-matching")
julia> using Pluto

@fonsp fonsp added frontend Concerning the HTML editor CM6 CodeMirror 6 labels Jan 3, 2025
@fonsp fonsp marked this pull request as ready for review January 17, 2025 12:46
@fonsp fonsp merged commit b7193cb into codemirror-savq Jan 17, 2025
12 of 13 checks passed
@fonsp fonsp deleted the remove-ast-pattern-matching branch January 17, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CM6 CodeMirror 6 frontend Concerning the HTML editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant